You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mohamed Nufail (JIRA)" <ji...@apache.org> on 2012/06/27 08:59:44 UTC

[jira] [Created] (DERBY-5834) Remove unused methods in NetPreparedStatement class

Mohamed Nufail created DERBY-5834:
-------------------------------------

             Summary: Remove unused methods in NetPreparedStatement class
                 Key: DERBY-5834
                 URL: https://issues.apache.org/jira/browse/DERBY-5834
             Project: Derby
          Issue Type: Task
          Components: Network Client
            Reporter: Mohamed Nufail


The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.

- resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section) 
- resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (DERBY-5834) Remove unused methods in NetPreparedStatement class

Posted by "Mohamed Nufail (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Nufail updated DERBY-5834:
----------------------------------

    Priority: Minor  (was: Major)
    
> Remove unused methods in NetPreparedStatement class
> ---------------------------------------------------
>
>                 Key: DERBY-5834
>                 URL: https://issues.apache.org/jira/browse/DERBY-5834
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>            Reporter: Mohamed Nufail
>            Priority: Minor
>         Attachments: derby-5834.patch
>
>
> The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section) 
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (DERBY-5834) Remove unused methods in NetPreparedStatement class

Posted by "Mohamed Nufail (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Nufail updated DERBY-5834:
----------------------------------

    Attachment: derby-5834.patch

derby-5834.patch removes these two methods
                
> Remove unused methods in NetPreparedStatement class
> ---------------------------------------------------
>
>                 Key: DERBY-5834
>                 URL: https://issues.apache.org/jira/browse/DERBY-5834
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>            Reporter: Mohamed Nufail
>            Priority: Minor
>         Attachments: derby-5834.patch
>
>
> The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section) 
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (DERBY-5834) Remove unused methods in NetPreparedStatement class

Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Pendleton resolved DERBY-5834.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.10.0.0
         Assignee: Mohamed Nufail

This patch looks great to me. I agree with the observation that
these overloads of the resetNetPreparedStatement method are
unused, and should be removed.

My builds and tests were successful, and I've committed this
patch to the trunk as revision 1356573.
                
> Remove unused methods in NetPreparedStatement class
> ---------------------------------------------------
>
>                 Key: DERBY-5834
>                 URL: https://issues.apache.org/jira/browse/DERBY-5834
>             Project: Derby
>          Issue Type: Task
>          Components: Network Client
>            Reporter: Mohamed Nufail
>            Assignee: Mohamed Nufail
>            Priority: Minor
>             Fix For: 10.10.0.0
>
>         Attachments: derby-5834.patch
>
>
> The following two methods in NetPreparedStatement class are never used. It might be possible to remove them.
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section) 
> - resetNetPreparedStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira