You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/01 21:42:28 UTC

[GitHub] [airflow] potiuk opened a new pull request, #30424: Rebname --test-types to --parallel-test-types parameters

potiuk opened a new pull request, #30424:
URL: https://github.com/apache/airflow/pull/30424

   The --test-type and --test-types parameters were very similar, but they have enough difference to differentiate them even more:
   
   The --test-type is specifically to run single test and it might include not only the regular "test-types" but also allow for cross-selection of tests from different other types (for example --test-type Postgres will run tests for Postgres database and they might come from Providers, Others, CLI etc.
   
   Where --test-types was generally foreseen to be able to split the tests into "sepearated" groups that could be run in parallel.
   
   The parameters have different defaults and even different choice of test type that you could choose from (and --test-types is a space-separated one to make it easier to pass it around in CI, where rather than passing multiple (variable number) of parameters, it's easier to pass a single, even space-separated list of tests to run.
   
   This change is good to show the difference between then parameters and to stress that they are really quite different, also it makes it easier to avoid confusion people might have especially that the name was easy to have typo in.
   
   In a way (but different than in the original issue it Fixes: #30407
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30424: Rename --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493403937

   Small quality of life improvement in breeze.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30424: Rebname --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493133630

   cc: @vandonr-amz  - I made changes to breeze w/regards providers and I recalled the discussion from #https://github.com/apache/airflow/issues/30407 and I found that it is **really** easy to just rename the --test-types parameter to avoid confusion . Here it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30424: Rename --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493149189

   I also correctedalm the Ci references. breeze is deliberately in Airflwo repo so that they can evolve together and so we do not have to care about backwards compatibility. And this paran is norlstly use d in CI - most people even if run parallel tests they would run it with default value (all tests).
   
   We have no expectations nor need about breeze being backwards compatible :) 
   
   I understand where  you're coming from but i think it is really the matter of wher you get 'common' part we are reusing a lot of code under the hood, and it's a bit arbitrary decision how to name parameters that internally might even consist of similar 'blocks' 
   
   In this case i'd say separating it MORE is better because it removes confusion and typos 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vandonr-amz commented on pull request #30424: Rebname --test-types to --parallel-test-types parameters

Posted by "vandonr-amz (via GitHub)" <gi...@apache.org>.
vandonr-amz commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493134837

   renaming the parameter is a breaking change though. Won't it break the CI here in github ?
   
   Also, I agree that the rename is a step in the right direction to reduce confusion, but I still think it's weird to have parameters that are very similar but slightly different and incompatible in their use :/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30424: Rename --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493151721

   I also correctedalm the Ci references. breeze is deliberately in Airflwo repo so that they can evolve together and so we do not have to care about backwards compatibility. And this paran is norlstly use d in CI - most people even if run parallel tests they would run it with default value (all tests).
   
   We have no expectations nor need about breeze being backwards compatible :) 
   
   I understand where  you're coming from but i think it is really the matter of wher you get 'common' part we are reusing a lot of code under the hood, and it's a bit arbitrary decision how to name parameters that internally might even consist of similar 'blocks' 
   
   In this case i'd say separating it MORE is better because it removes confusion and typos 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #30424: Rename --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30424:
URL: https://github.com/apache/airflow/pull/30424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #30424: Rename --test-types to --parallel-test-types parameters

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30424:
URL: https://github.com/apache/airflow/pull/30424#issuecomment-1493152246

   But of course if you would like to propose a PR changing it + i am happy to discuss seeing the code :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org