You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/02/03 20:09:45 UTC
[GitHub] [arrow] rtpsw opened a new pull request, #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
rtpsw opened a new pull request, #34036:
URL: https://github.com/apache/arrow/pull/34036
See #34035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096272086
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -36,7 +36,6 @@
#include "arrow/util/logging.h"
#include "arrow/util/mutex.h"
#include "arrow/util/thread_pool.h"
-#include "arrow/util/tracing_internal.h"
Review Comment:
Though this won't break an external project build, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34036:
URL: https://github.com/apache/arrow/pull/34036#issuecomment-1416350949
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34036: GH-34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34036:
URL: https://github.com/apache/arrow/pull/34036#issuecomment-1416695458
Benchmark runs are scheduled for baseline = 54eedb95ec504a715d557e71139ae4df9657fde6 and contender = b29441c32447096802ea71135efe911817b84330. b29441c32447096802ea71135efe911817b84330 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1fe4e173f2d249cd83b04134b10845f1...f746c7b916c9435aa547f18f1fd8b5f5/)
[Failed :arrow_down:0.61% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cf38c4686b2e4e6ba7b9895f42434703...0a2415aef98f47f580cd34458d1de8dc/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5bce3d8e3cbf445a838ab012dbe4cb11...f5f9b73395be47bab3f7cec426f02b88/)
[Finished :arrow_down:0.63% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ef1d5d6e055642ab98c306bfbe40d326...546ae607cf10472ca4e403717c590eb5/)
Buildkite builds:
[Finished] [`b29441c3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2322)
[Failed] [`b29441c3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2350)
[Finished] [`b29441c3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2320)
[Finished] [`b29441c3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2341)
[Finished] [`54eedb95` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2321)
[Finished] [`54eedb95` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2348)
[Finished] [`54eedb95` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2318)
[Finished] [`54eedb95` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2339)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096276137
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -57,6 +56,15 @@
#endif
namespace arrow {
+
+namespace internal {
+namespace tracing {
+
+struct Scope;
+
+} // namespace tracing
+} // namespace internal
+
Review Comment:
Handling this in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096268449
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -57,6 +56,15 @@
#endif
namespace arrow {
+
+namespace internal {
+namespace tracing {
+
+struct Scope;
+
+} // namespace tracing
+} // namespace internal
+
Review Comment:
Can we instead add `Scope` to `arrow/util/type_fwd.h` (and include that here)
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -234,6 +242,8 @@ class bit_util {
} // namespace util
namespace compute {
+class ExecNode;
Review Comment:
Instead can we include `arrow/compute/type_fwd.h`?
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -36,7 +36,6 @@
#include "arrow/util/logging.h"
#include "arrow/util/mutex.h"
#include "arrow/util/thread_pool.h"
-#include "arrow/util/tracing_internal.h"
Review Comment:
Note, this header is still an internal header as it includes `arrow/util/logging.h` which is perhaps our most egregious improperly named header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34036: GH-34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34036:
URL: https://github.com/apache/arrow/pull/34036#issuecomment-1416695495
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/cf38c4686b2e4e6ba7b9895f42434703...0a2415aef98f47f580cd34458d1de8dc/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5bce3d8e3cbf445a838ab012dbe4cb11...f5f9b73395be47bab3f7cec426f02b88/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096276490
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -234,6 +242,8 @@ class bit_util {
} // namespace util
namespace compute {
+class ExecNode;
Review Comment:
Looks like the header is already included and the forward declaration here can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34036: GH-34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34036:
URL: https://github.com/apache/arrow/pull/34036#issuecomment-1416476956
* Closes: #34035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #34036: GH-34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #34036:
URL: https://github.com/apache/arrow/pull/34036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096281603
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -36,7 +36,6 @@
#include "arrow/util/logging.h"
#include "arrow/util/mutex.h"
#include "arrow/util/thread_pool.h"
-#include "arrow/util/tracing_internal.h"
Review Comment:
Ah, I don't know. But we have a check that ensures we don't expose `logging.h` from `api.h`. So we need to keep `map_node.h` out of `api.h` until this is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on a diff in pull request #34036: GH 34035: [C++] Internal header file included from public one breaks build of external projects
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on code in PR #34036:
URL: https://github.com/apache/arrow/pull/34036#discussion_r1096283869
##########
cpp/src/arrow/compute/exec/util.h:
##########
@@ -36,7 +36,6 @@
#include "arrow/util/logging.h"
#include "arrow/util/mutex.h"
#include "arrow/util/thread_pool.h"
-#include "arrow/util/tracing_internal.h"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org