You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/03/18 21:18:31 UTC
Review Request 45047: GEODE-956 Product use log shows duplicate
entries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45047/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
The product use logger was adding up the load of all of the servers and displaying it, but each load is a float between zero and 1.0 so the total was always zero. I've modified it to figure out the correct connection count for each CacheServer and also log the subscription queue count.
The list of servers now has duplicate entries removed by putting all of the servers into a Set.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 6fe1c6b7e15637daf130c7dc145dfc905988ac3e
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/LocatorListResponse.java a9ab821d9a96f21dde4358a417d2b5498ced881e
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java 644bf63d5bcf2c4cc3daf1c7a0372589cdc7e613
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/ProductUseLogDUnitTest.java 149d6d89ce7e5cc2a52a244cdec04ba5483398cb
Diff: https://reviews.apache.org/r/45047/diff/
Testing
-------
new tests in ProductUseLogDUnitTest. precheckin is running
Thanks,
Bruce Schuchardt
Re: Review Request 45047: GEODE-956 Product use log shows duplicate
entries
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45047/#review124278
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On March 18, 2016, 8:18 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45047/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 8:18 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The product use logger was adding up the load of all of the servers and displaying it, but each load is a float between zero and 1.0 so the total was always zero. I've modified it to figure out the correct connection count for each CacheServer and also log the subscription queue count.
>
> The list of servers now has duplicate entries removed by putting all of the servers into a Set.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImpl.java 6fe1c6b7e15637daf130c7dc145dfc905988ac3e
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/locator/LocatorListResponse.java a9ab821d9a96f21dde4358a417d2b5498ced881e
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java 644bf63d5bcf2c4cc3daf1c7a0372589cdc7e613
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/ProductUseLogDUnitTest.java 149d6d89ce7e5cc2a52a244cdec04ba5483398cb
>
> Diff: https://reviews.apache.org/r/45047/diff/
>
>
> Testing
> -------
>
> new tests in ProductUseLogDUnitTest. precheckin is running
>
>
> Thanks,
>
> Bruce Schuchardt
>
>