You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "Bruno P. Kinoshita (Jira)" <ji...@apache.org> on 2023/02/09 14:07:00 UTC

[jira] [Comment Edited] (OPENNLP-1447) Move from System.out/System.err to SLF4J

    [ https://issues.apache.org/jira/browse/OPENNLP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686534#comment-17686534 ] 

Bruno P. Kinoshita edited comment on OPENNLP-1447 at 2/9/23 2:06 PM:
---------------------------------------------------------------------

For tests that rely on capturing the process output, maybe something like what's described on these SO answers could work? [https://stackoverflow.com/questions/29076981/how-to-intercept-slf4j-with-logback-logging-via-a-junit-test]

However, I think we still need to review if these tests have to be kept as they are (i.e. writing to some output stream) or if they should be re-written at an Java object input/output level, instead of I/O.


was (Author: kinow):
For tests that rely on capturing the process output, maybe something like what's described on these SO answers could work? https://stackoverflow.com/questions/29076981/how-to-intercept-slf4j-with-logback-logging-via-a-junit-test

> Move from System.out/System.err to SLF4J
> ----------------------------------------
>
>                 Key: OPENNLP-1447
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1447
>             Project: OpenNLP
>          Issue Type: Epic
>            Reporter: Richard Zowalla
>            Priority: Major
>
> As discussed on the mailing list, we are in favour of moving from System.out / System.err to proper log output.
> The discussion is here: https://lists.apache.org/thread/vt748qbz5onhwhh70kky9wk1o5zm42tm
> To reduce reviewer burden, we should tackle the task in several steps.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)