You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "onerishabh (via GitHub)" <gi...@apache.org> on 2023/08/03 03:57:20 UTC
[GitHub] [iceberg] onerishabh opened a new pull request, #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
onerishabh opened a new pull request, #8214:
URL: https://github.com/apache/iceberg/pull/8214
* Enable converting objects of `date`, `time` and `datetime` types to bytes.
* Uses `pyiceberg/utils/datetime.py` functions to convert date/timestamp to epoch microseconds.
* Uses _LONG_STRUCT to pack epoch microseconds.
* Uses _INT_STRUCT to pack number of days since epoch.
Issue: #8191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] onerishabh commented on pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "onerishabh (via GitHub)" <gi...@apache.org>.
onerishabh commented on PR #8214:
URL: https://github.com/apache/iceberg/pull/8214#issuecomment-1665479550
Wohoooo 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] onerishabh commented on pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "onerishabh (via GitHub)" <gi...@apache.org>.
onerishabh commented on PR #8214:
URL: https://github.com/apache/iceberg/pull/8214#issuecomment-1664837068
@Fokko , have a look now. Added a new function to do this testing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #8214:
URL: https://github.com/apache/iceberg/pull/8214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] onerishabh commented on pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "onerishabh (via GitHub)" <gi...@apache.org>.
onerishabh commented on PR #8214:
URL: https://github.com/apache/iceberg/pull/8214#issuecomment-1663969650
> This is great @onerishabh, can you throw in some tests in `test_conversions.py`?
tests added as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #8214:
URL: https://github.com/apache/iceberg/pull/8214#issuecomment-1663910757
This is great @onerishabh, can you throw in some tests in `test_conversions.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #8214: Python: Add support `date`, `time` and `datetime` in to_bytes
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #8214:
URL: https://github.com/apache/iceberg/pull/8214#issuecomment-1664618023
@onerishabh Sorry, I was not specific about the testing. I think we're super close, but I would love to see tests like:
```python
to_bytes(DateType(), date(1925, 1, 1)) == b"..."
```
For the `date`, `time` and `datetime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org