You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/08 05:11:03 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

1996fanrui opened a new pull request, #20214:
URL: https://github.com/apache/flink/pull/20214

   ## What is the purpose of the change
   
   Fix the wrong timestamp unit of KafkaSource.
   
   ## Brief change log
   
   Fix the wrong timestamp unit of KafkaSource.
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] PatrickRen commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
PatrickRen commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179878678

   @1996fanrui Merged to master. Also could you back port the commit to 1.14 and 1.15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179909721

   Hi @PatrickRen , I have submitted #20237  and #20238  to back port this PR to 1.14 and 1.15.
   
   1.15 is the same as this PR.
   1.14 don't have KafkaSource Chinese doc, so the PR of 1.14 miss a change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179728676

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1178562814

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2e3e781743dcc3237221b231dedb2ba88d4c29cb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2e3e781743dcc3237221b231dedb2ba88d4c29cb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2e3e781743dcc3237221b231dedb2ba88d4c29cb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179089090

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1178583874

   Hi @PatrickRen , could you help review in your free time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179649056

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] PatrickRen merged pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
PatrickRen merged PR #20214:
URL: https://github.com/apache/flink/pull/20214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #20214: [FLINK-28454][kafka][docs] Fix the wrong timestamp unit of KafkaSource

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #20214:
URL: https://github.com/apache/flink/pull/20214#issuecomment-1179899413

   > @1996fanrui Merged to master. Also could you back port the commit to 1.14 and 1.15?
   
   Thanks for your review, I will do it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org