[GitHub] [hive] szlta commented on a change in pull request #2523: HIVE-25376

[GitBox <gi...@apache.org>]

szlta commented on a change in pull request #2523:
URL: https://github.com/apache/hive/pull/2523#discussion_r675969829



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java
##########
@@ -60,7 +61,8 @@ private HiveVectorizedReader() {
 
   public static <D> CloseableIterable<D> reader(InputFile inputFile, FileScanTask task, Map<Integer, ?> idToConstant,
       TaskAttemptContext context) {
-    JobConf job = (JobConf) context.getConfiguration();
+    // Tweaks on jobConf here are relevant for this task only, so we need to copy it first as context's conf is reused..

Review comment:
       Hm what I meant is that any changes we make to the jobConf instance in the code below, should not affect anyone else. And for that reason I need to take a copy of it and do the adjustments on the copied instance.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org