You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/12/12 22:44:19 UTC
Review Request 64556: Made master acknowledge unknown operations
during agent reconciliation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64556/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
Repository: mesos
Description
-------
Made master acknowledge unknown operations during agent reconciliation.
Diffs
-----
src/master/master.cpp efe8b8f1704b314e6e6a4d5632718cab2854e38f
Diff: https://reviews.apache.org/r/64556/diff/1/
Testing
-------
make check
Thanks,
Greg Mann
Re: Review Request 64556: Made master acknowledge unknown operations
during agent reconciliation.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 14, 2017, 1:58 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 7675-7679 (patched)
> > <https://reviews.apache.org/r/64556/diff/1/?file=1914840#file1914840line7675>
> >
> > Hum, in that case, why not just rely on SUM to retry and master will reply with ACK? I feel this is not necessary.
> >
> > If you think it's needed, look like no need to send ACK for agent default resources? Sounds like not necesary?
Yea thanks Jie, I think this is unnecessary.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64556/#review193752
-----------------------------------------------------------
On Dec. 12, 2017, 10:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64556/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 10:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made master acknowledge unknown operations during agent reconciliation.
>
>
> Diffs
> -----
>
> src/master/master.cpp efe8b8f1704b314e6e6a4d5632718cab2854e38f
>
>
> Diff: https://reviews.apache.org/r/64556/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64556: Made master acknowledge unknown operations
during agent reconciliation.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64556/#review193752
-----------------------------------------------------------
src/master/master.cpp
Lines 7675-7679 (patched)
<https://reviews.apache.org/r/64556/#comment272390>
Hum, in that case, why not just rely on SUM to retry and master will reply with ACK? I feel this is not necessary.
If you think it's needed, look like no need to send ACK for agent default resources? Sounds like not necesary?
- Jie Yu
On Dec. 12, 2017, 10:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64556/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 10:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made master acknowledge unknown operations during agent reconciliation.
>
>
> Diffs
> -----
>
> src/master/master.cpp efe8b8f1704b314e6e6a4d5632718cab2854e38f
>
>
> Diff: https://reviews.apache.org/r/64556/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 64556: Made master acknowledge unknown operations
during agent reconciliation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64556/#review193627
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64504', '64505', '64556']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64556
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64556/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2305 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2326 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2249 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2272 ms total)
[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (307350 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 204 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64556/logs/mesos-tests-stderr.log):
```
I1212 23:57:17.661146 2968 master.cpp:10180] Updating the state of task 6370c5dd-2df9-4e98-9c6c-6803a1f9f420 of framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1212 23:57:17.661146 6216 slave.cpp:3400] Shutting down framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000
I1212 23:57:17.662165 6216 slave.cpp:6091] Shutting down executor '6370c5dd-2df9-4e98-9c6c-6803a1f9f420' of framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000 at executor(1)@10.3.1.5:54314
I1212 23:57:17.663148 6216 slave.cpp:909] Agent terminating
I1212 23:57:17.663148 2968 master.cpp:10286] Removing task 6370c5dd-2df9-4e98-9c6c-6803a1f9f420 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000 on agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0 at slave(326)@10.3.1.5:54293 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 23:57:17.666147 8904 hierarchical.cpp:344] Removed framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000
W1212 23:57:17.666147 6216 slave.cpp:3396] Ignoring shutdown framework 4e8d03ca-2776-40f0-87af-2d7c956024ea-0000 because it is terminating
I1212 23:57:17.667157 2968 master.cpp:1305] Agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0 at slave(326)@10.3.I1212 23:57:17.001132 4772 exec.cpp:162] Version: 1.5.0
I1212 23:57:17.024132 2876 exec.cpp:237] Executor registered on agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0
I1212 23:57:17.027130 2616 executor.cpp:171] Received SUBSCRIBED event
I1212 23:57:17.031128 2616 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1212 23:57:17.031128 2616 executor.cpp:171] Received LAUNCH event
I1212 23:57:17.035132 2616 executor.cpp:637] Starting task 6370c5dd-2df9-4e98-9c6c-6803a1f9f420
I1212 23:57:17.112140 2616 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1212 23:57:17.638144 2616 executor.cpp:650] Forked command at 7868
I1212 23:57:17.666147 6504 exec.cpp:435] Executor asked to shutdown
I1212 23:57:17.667157 880 executor.cpp:171] Received SHUTDOWN event
I1212 23:57:17.667157 880 executor.cpp:747] Shutting down
I1212 23:57:17.667157 880 executor.cpp:854] Sending SIGTERM to process tree at pid 71.5:54293 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1212 23:57:17.667157 2968 master.cpp:3364] Disconnecting agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0 at slave(326)@10.3.1.5:54293 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 23:57:17.667157 2968 master.cpp:3383] Deactivating agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0 at slave(326)@10.3.1.5:54293 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 23:57:17.668148 6772 hierarchical.cpp:766] Agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0 deactivated
I1212 23:57:17.669148 1032 containerizer.cpp:2328] Destroying container 3af9c58d-9ec1-4ca6-a278-c6eb07ddefff in RUNNING state
I1212 23:57:17.669148 1032 containerizer.cpp:2930] Transitioning the state of container 3af9c58d-9ec1-4ca6-a278-c6eb07ddefff from RUNNING to DESTROYING
I1212 23:57:17.669148 1032 launcher.cpp:156] Asked to destroy container 3af9c58d-9ec1-4ca6-a278-c6eb07ddefff
I1212 23:57:17.685649 9156 containerizer.cpp:2779] Container 3af9c58d-9ec1-4ca6-a278-c6eb07ddefff has exited
I1212 23:57:17.713753 7836 master.cpp:1147] Master terminating
I1212 23:57:17.715848 6216 hierarchical.cpp:609] Removed agent 4e8d03ca-2776-40f0-87af-2d7c956024ea-S0
I1212 23:57:18.005770 1204 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 12, 2017, 10:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64556/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 10:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made master acknowledge unknown operations during agent reconciliation.
>
>
> Diffs
> -----
>
> src/master/master.cpp efe8b8f1704b314e6e6a4d5632718cab2854e38f
>
>
> Diff: https://reviews.apache.org/r/64556/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Greg Mann
>
>