[GitHub] Myasuka commented on a change in pull request #7009: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy

[GitBox <gi...@apache.org>]

Myasuka commented on a change in pull request #7009: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7009#discussion_r245872618
 
 

 ##########
 File path: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/RollingSinkFaultToleranceITCase.java
 ##########
 @@ -77,8 +77,8 @@
 
 	private static String outPath;
 
-	@BeforeClass
-	public static void createHDFS() throws IOException {
+	@Before
 
 Review comment:
   This is because its parent `StreamFaultToleranceTestBase` introduced parameterized test for two different failover strategies, for which I want to verify whether streaming programs could still be fault tolerant with `RestartPipelinedRegionStrategy`. However, files on hdfs left within `RollingSinkFaultToleranceITCase` after this test has run once would cause it failed in the new run with another strategy. That's why I have to modify this test.
   I think after this PR, [FLINK-10713](https://issues.apache.org/jira/browse/FLINK-10713) should also add `RestartIndividualStrategy` into `StreamFaultToleranceTestBase`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services