[GitHub] [wicket] solomax commented on a change in pull request #474: Java 9+ module-aware Wicket 9.x

[GitBox <gi...@apache.org>]

solomax commented on a change in pull request #474:
URL: https://github.com/apache/wicket/pull/474#discussion_r663311532



##########
File path: pom.xml
##########
@@ -142,6 +142,7 @@
 		<commons-collections.version>3.2.2</commons-collections.version>
 		<commons-collections4.version>4.4</commons-collections4.version>
 		<commons-fileupload.version>1.4</commons-fileupload.version>
+<!--		<commons-fileupload.version>0.68.0.1</commons-fileupload.version>-->

Review comment:
       I guess this one can be removed

##########
File path: pom.xml
##########
@@ -169,7 +170,7 @@
 		<mockito.version>3.11.1</mockito.version>
 		<objenesis.version>3.2</objenesis.version>
 		<openjson.version>1.0.12</openjson.version>
-		<slf4j.version>1.7.25</slf4j.version>
+		<slf4j.version>2.0.0-alpha1</slf4j.version>

Review comment:
       Why to update to `alpha`?

##########
File path: pom.xml
##########
@@ -290,6 +290,7 @@
 				<version>${commons-fileupload.version}</version>
 				<exclusions>
 					<exclusion>
+<!--						<groupId>com.jwebmp.jpms.commons</groupId>-->

Review comment:
       I guess this one can be dropped




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org