You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/02/06 18:53:24 UTC
[GitHub] nifi-minifi-cpp pull request #260: MINIFICPP-382: Implement SUSE release sup...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/260
MINIFICPP-382: Implement SUSE release support for SUSE and SLES12
Signed-off-by: Marc Parisi <ph...@apache.org>
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-382
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit 8e7b2b7c477c9da28a71b0663c6834cadaf2e38a
Author: Marc Parisi <ph...@...>
Date: 2018-01-24T14:05:19Z
MINIFICPP-382: Implement SUSE release support for SUSE and SLES12
Signed-off-by: Marc Parisi <ph...@apache.org>
----
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
@phrocker I had run into a small hiccup when initially reviewing on SLES 12 SP3 which was probably more a product of my lack of familiarity with SUSE. I needed to first enable the SLES SDK repository after activating my install. This was accomplished via yast. After that, I was able to pull down all the devel dependencies. Build and testing went fine. +1 from me. Might be helpful to have a note about that dependency first. not sure if bootstrap or readme makes more sense.
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
grabbed me some ISOs, will scope out
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by minifirocks <gi...@git.apache.org>.
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
Looks good.
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
@apiri I made an update to the readme last night.
https://github.com/apache/nifi-minifi-cpp/pull/260/commits/7a3e81066c007053adc77a315f490e44671cbd34
---
[GitHub] nifi-minifi-cpp pull request #260: MINIFICPP-382: Implement SUSE release sup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/260
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
@phrocker great, thanks will get this merged. sorry didn't notice the update.
---
[GitHub] nifi-minifi-cpp issue #260: MINIFICPP-382: Implement SUSE release support fo...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
How fitting, a unit test is seg faulting....I'll check and update.
---