You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/09/14 12:57:56 UTC

Review Request 38350: FALCON-1437: Change DR recipes notification with Falcon notification

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38350/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1437
    https://issues.apache.org/jira/browse/FALCON-1437


Repository: falcon-git


Description
-------

Presently DR recipes uses Oozie email action for notification, it must be updated to use Falcon notification.


Diffs
-----

  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-template.xml de0f748 
  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml e35773f 
  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties 64ab6b8 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-template.xml 3afbef0 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 7362c2e 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure.properties b2d670a 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-template.xml 3afbef0 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml c441998 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties 42ae30b 
  client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java 5df9b0a 
  client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 9522816 
  webapp/src/test/resources/hdfs-replication-template.xml b93cc0b 
  webapp/src/test/resources/hdfs-replication.properties 1b485b4 

Diff: https://reviews.apache.org/r/38350/diff/


Testing
-------

Yes. This patch need to applied after patch from FALCON-1425 has been applied.


Thanks,

Peeyush Bishnoi


Re: Review Request 38350: FALCON-1437: Change DR recipes notification with Falcon notification

Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38350/
-----------------------------------------------------------

(Updated Sept. 21, 2015, 7:47 a.m.)


Review request for Falcon.


Bugs: FALCON-1437
    https://issues.apache.org/jira/browse/FALCON-1437


Repository: falcon-git


Description
-------

Presently DR recipes uses Oozie email action for notification, it must be updated to use Falcon notification.


Diffs (updated)
-----

  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-template.xml de0f748 
  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml e35773f 
  addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties 64ab6b8 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-template.xml 3afbef0 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 7362c2e 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure.properties b2d670a 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-template.xml 3afbef0 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml c441998 
  addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties 42ae30b 
  client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java 5df9b0a 
  client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 9522816 
  webapp/src/test/resources/hdfs-replication-template.xml b93cc0b 
  webapp/src/test/resources/hdfs-replication.properties 1b485b4 

Diff: https://reviews.apache.org/r/38350/diff/


Testing
-------

Yes. This patch need to applied after patch from FALCON-1425 has been applied.


Thanks,

Peeyush Bishnoi


Re: Review Request 38350: FALCON-1437: Change DR recipes notification with Falcon notification

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38350/#review99674
-----------------------------------------------------------

Ship it!


After fixing Sowmya's comments.   Generally we need to add more unit tests for recipes and dr scenarios.  We should take it up for post 0.8 release

- Venkat Ranganathan


On Sept. 14, 2015, 3:57 a.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38350/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 3:57 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1437
>     https://issues.apache.org/jira/browse/FALCON-1437
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Presently DR recipes uses Oozie email action for notification, it must be updated to use Falcon notification.
> 
> 
> Diffs
> -----
> 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-template.xml de0f748 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication-workflow.xml e35773f 
>   addons/recipes/hdfs-replication/src/main/resources/hdfs-replication.properties 64ab6b8 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-template.xml 3afbef0 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 7362c2e 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure.properties b2d670a 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-template.xml 3afbef0 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml c441998 
>   addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery.properties 42ae30b 
>   client/src/main/java/org/apache/falcon/recipe/RecipeToolOptions.java 5df9b0a 
>   client/src/main/java/org/apache/falcon/recipe/util/RecipeProcessBuilderUtils.java 9522816 
>   webapp/src/test/resources/hdfs-replication-template.xml b93cc0b 
>   webapp/src/test/resources/hdfs-replication.properties 1b485b4 
> 
> Diff: https://reviews.apache.org/r/38350/diff/
> 
> 
> Testing
> -------
> 
> Yes. This patch need to applied after patch from FALCON-1425 has been applied.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>