You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by squito <gi...@git.apache.org> on 2018/01/26 17:54:35 UTC

[GitHub] spark pull request #20408: [SPARK-23189][Core][Web UI] Reflect stage level b...

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20408#discussion_r164175040
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/executorspage.js ---
    @@ -25,9 +25,13 @@ function getThreadDumpEnabled() {
         return threadDumpEnabled;
     }
     
    -function formatStatus(status, type) {
    +function formatStatus(status, type, row) {
    --- End diff --
    
    can you move the
    
    ```js
    if (row.isBlacklisted) return "Blacklisted";
    ```
    into this function as well?  no reason for it to be separated.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org