You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Paul Kronenwetter (JIRA)" <ji...@apache.org> on 2007/04/16 00:29:15 UTC
[jira] Created: (FOR-991) PluginGallery misbehaves on images having
multiple "dots" in the filename. Venus.11.JPG as an example.
PluginGallery misbehaves on images having multiple "dots" in the filename. Venus.11.JPG as an example.
-------------------------------------------------------------------------------------------------------
Key: FOR-991
URL: https://issues.apache.org/jira/browse/FOR-991
Project: Forrest
Issue Type: Bug
Components: Plugin: input.PhotoGallery
Affects Versions: 0.8-dev
Reporter: Paul Kronenwetter
Priority: Minor
Images with multiple "dots" in the filename are handled incorrectly. From CFAS's broken-links.xml:
<link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/Venus.jpg (No such file or directory)" uri="/gallery/planet/V
enus.small.jpg">
<referrer uri="/gallery/planet/pic_4.html"/>
</link>
However, the source file is: Venus.11.JPG, under xdocs/images/gallery/planet. I realize this may overlap JIRA FOR-990, so I'll do some additional testing with the file as Venus.11.jpg and report later.
Unfortunately, this is the only file I currently have with multiple "dots" in the filename.
The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-991) PluginGallery misbehaves on images
having multiple "dots" in the filename. Venus.11.JPG as an example.
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488982 ]
Gavin commented on FOR-991:
---------------------------
Images are being converted to @src using the dot as a reference point and so the second dot and anything inbetween are being lost.
Such as
<img src="{substring-before(@name, '.')}.small.jpg" />
> PluginGallery misbehaves on images having multiple "dots" in the filename. Venus.11.JPG as an example.
> -------------------------------------------------------------------------------------------------------
>
> Key: FOR-991
> URL: https://issues.apache.org/jira/browse/FOR-991
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images with multiple "dots" in the filename are handled incorrectly. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/Venus.jpg (No such file or directory)" uri="/gallery/planet/V
> enus.small.jpg">
> <referrer uri="/gallery/planet/pic_4.html"/>
> </link>
> However, the source file is: Venus.11.JPG, under xdocs/images/gallery/planet. I realize this may overlap JIRA FOR-990, so I'll do some additional testing with the file as Venus.11.jpg and report later.
> Unfortunately, this is the only file I currently have with multiple "dots" in the filename.
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-991) PluginGallery misbehaves on images
having multiple "dots" in the filename. Venus.11.JPG as an example.
Posted by "Paul Kronenwetter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488995 ]
Paul Kronenwetter commented on FOR-991:
---------------------------------------
Gavin, you are correct. I found the places where the substring-before references were used in the PhotoGallery and changed them to be more like this:
<img src="{substring-before(@name, '.jpg')}.small.jpg" />
It works, but it's not extensible or flexible. Though right now the PhotoGallery plug in only deals with JPEG files anyway. I wonder if this is good enough, or if this is even worth fixing.
Thoughts on either the fix or the overall usefulness of fixing this?
-Paul
> PluginGallery misbehaves on images having multiple "dots" in the filename. Venus.11.JPG as an example.
> -------------------------------------------------------------------------------------------------------
>
> Key: FOR-991
> URL: https://issues.apache.org/jira/browse/FOR-991
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images with multiple "dots" in the filename are handled incorrectly. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/Venus.jpg (No such file or directory)" uri="/gallery/planet/V
> enus.small.jpg">
> <referrer uri="/gallery/planet/pic_4.html"/>
> </link>
> However, the source file is: Venus.11.JPG, under xdocs/images/gallery/planet. I realize this may overlap JIRA FOR-990, so I'll do some additional testing with the file as Venus.11.jpg and report later.
> Unfortunately, this is the only file I currently have with multiple "dots" in the filename.
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-991) PluginGallery misbehaves on images
having multiple "dots" in the filename. Venus.11.JPG as an example.
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489040 ]
Ross Gardler commented on FOR-991:
----------------------------------
This kind of issue comes up now and again.
Some time ago we decided that all plugins should use paths, not extensions, i.e. instead of:
<img src="{substring-before(@name, '.jpg')}.small.jpg" />
We would have something like:
<img src="small/{substring-before(@name, '.jpg')}.jpg" />
Clearly this needs to be acted upon within the photAlbum plugin
> PluginGallery misbehaves on images having multiple "dots" in the filename. Venus.11.JPG as an example.
> -------------------------------------------------------------------------------------------------------
>
> Key: FOR-991
> URL: https://issues.apache.org/jira/browse/FOR-991
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images with multiple "dots" in the filename are handled incorrectly. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/Venus.jpg (No such file or directory)" uri="/gallery/planet/V
> enus.small.jpg">
> <referrer uri="/gallery/planet/pic_4.html"/>
> </link>
> However, the source file is: Venus.11.JPG, under xdocs/images/gallery/planet. I realize this may overlap JIRA FOR-990, so I'll do some additional testing with the file as Venus.11.jpg and report later.
> Unfortunately, this is the only file I currently have with multiple "dots" in the filename.
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.