You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/11/09 01:29:32 UTC
[jira] Created: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Bulk loading script makes regions incorrectly (loadtable.rb)
------------------------------------------------------------
Key: HBASE-1962
URL: https://issues.apache.org/jira/browse/HBASE-1962
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
>From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1962:
-------------------------
Fix Version/s: (was: 0.20.2)
(was: 0.21.0)
0.20.3
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791200#action_12791200 ]
stack commented on HBASE-1962:
------------------------------
@Ioannis and @Murali: This should be fixed in TRUNK and branch now (Because of https://issues.apache.org/jira/browse/HBASE-2034). My bad for missing applying Murali's patch. I'm going to close this issue. Lets open new one if still not fixed.
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "Murali Krishna P (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Murali Krishna P updated HBASE-1962:
------------------------------------
Status: Patch Available (was: Open)
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 1962.patch
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-1962.
--------------------------
Resolution: Fixed
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778195#action_12778195 ]
stack commented on HBASE-1962:
------------------------------
It looks like its applied to trunk? Not branch? Please fix though if its just a case of branch, lets wait till 0.20.2 clears?
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.2, 0.21.0
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782128#action_12782128 ]
stack commented on HBASE-1962:
------------------------------
Jon: I took a look. There is a descendingIterator in TreeSet: http://www.j2ee.me/javase/6/docs/api/java/util/TreeSet.html#descendingIterator%28%29. Can we close this issue?
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1962:
-------------------------
Attachment: 1962.patch
We were looking at hfile metainfo and making regions that went from file lastkey to lastkey instead of from EMPTY_ROW to startkey (of second file) and then startkey to startkey of 3rd file, and so on.
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 1962.patch
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778180#action_12778180 ]
Jonathan Gray commented on HBASE-1962:
--------------------------------------
Was this actually committed? Looking at the loadtable script, it has at least one bug but does seem to work otherwise once that is fixed.
Right now, in 0.20 branch, the loop over the TreeMap uses:
{noformat}
for i in map.descendingIterator()
{noformat}
Unfortunately, TreeMap.descendingIterator() does not exist. This needs to be TreeMap.descendingKeySet().iterator() or the like.
@Stack, in the patch in this issue it looks right, but not up in SVN. Also, I don't see SVN commits linked in to the jira.
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.2, 0.21.0
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1962:
-------------------------
Attachment: delete_table.rb
Script for Murali to help fix damage done by bad addtable.rb
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "Murali Krishna P (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Murali Krishna P updated HBASE-1962:
------------------------------------
Attachment: 1962.patch_1
Couple of typos and a strange bug in that patch.
navigableKeySet().descendingIterator() didn't work as expected.
Please review
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: 1962.patch, 1962.patch_1
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1962:
-------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
0.20.2
Status: Resolved (was: Patch Available)
Applied fix to trunk and branch. Thanks Murali for testing.
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.2, 0.21.0
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-1962:
--------------------------
Assignee: stack
Reopen to apply properly to trunk
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.2, 0.21.0
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "Murali Krishna P (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789845#action_12789845 ]
Murali Krishna P commented on HBASE-1962:
-----------------------------------------
Yup, I did attach a patch for that. Looks like that was not checked in.
https://issues.apache.org/jira/secure/attachment/12424349/1962.patch_1
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1962) Bulk loading script makes regions
incorrectly (loadtable.rb)
Posted by "Ioannis Konstantinou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789740#action_12789740 ]
Ioannis Konstantinou commented on HBASE-1962:
---------------------------------------------
The descendingIterator method exists for TreeSet object, not TreeMap object. The error still occurs at version 0.20.2. If you change the line 111 of loadtable.rb from "for i in map.descendingIterator()" to "for i in map.descendingKeySet().iterator()" the script works ok.
> Bulk loading script makes regions incorrectly (loadtable.rb)
> ------------------------------------------------------------
>
> Key: HBASE-1962
> URL: https://issues.apache.org/jira/browse/HBASE-1962
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.3
>
> Attachments: 1962.patch, 1962.patch_1, delete_table.rb
>
>
> From mailing list, Murali Krishna found that loadtable.rb is not making regions correctly from the passed hfiles.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.