You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "YimingQiao (via GitHub)" <gi...@apache.org> on 2026/08/24 06:35:53 UTC
[PR] Fix BinaryViewArray construction after buffer ownership API change [arrow-rs]
YimingQiao opened a new pull request, #10814:
URL: https://github.com/apache/arrow-rs/pull/10814
Fixes the parquet-variant-compute compilation failure introduced when #10708 was merged after #10640.
BinaryViewArray::new_unchecked now expects Arc<[Buffer]>, but the call added by #10640 still passed Vec<Buffer>. This converts the newly constructed buffer vector into the required shared slice.
Verified with:
- cargo fmt --all -- --check
- cargo check -p parquet-variant-compute --all-targets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BinaryViewArray construction after buffer ownership API change [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #10814:
URL: https://github.com/apache/arrow-rs/pull/10814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BinaryViewArray construction after buffer ownership API change [arrow-rs]
Posted by "YimingQiao (via GitHub)" <gi...@apache.org>.
YimingQiao commented on PR #10814:
URL: https://github.com/apache/arrow-rs/pull/10814#issuecomment-5391626094
@Jefffrey FYI, #10708 and #10640 interacted and currently leave main unable to compile. This is the one-line follow-up fix; the targeted checks pass locally. Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BinaryViewArray construction after buffer ownership API change [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10814:
URL: https://github.com/apache/arrow-rs/pull/10814#issuecomment-5391851328
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org