You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "runzhiwang (Jira)" <ji...@apache.org> on 2020/12/30 07:04:00 UTC

[jira] [Commented] (RATIS-1272) Remove unused slf4j-log4j12 dependency

    [ https://issues.apache.org/jira/browse/RATIS-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256338#comment-17256338 ] 

runzhiwang commented on RATIS-1272:
-----------------------------------

[~szetszwo]  Hi, this pr seems has some problem. 
With this pr, when I start ratis with following command: 

{code:java}
nohup ${BIN}/server.sh filestore server --id n0 --storage /data/ratis/n0 --storage /data1/ratis/n0 --storage /data2/ratis/n0 --storage /data3/ratis/n0 --storage /data4/ratis/n0 --storage /data5/ratis/n0 --storage /data6/ratis/n0 --storage /data7/ratis/n0 --storage /data8/ratis/n0 --storage /data9/ratis/n0 --storage /data10/ratis/n0 --storage /data11/ratis/n0 --peers ${PEERS} --writeThreadNum 100 --readThreadNum 100 --commitThreadNum 20 --deleteThreadNum 20 >> n0.log 2>&1 &
{code}

n0.log only print following message:
 !screenshot-1.png! 

Then I revert this pr, n0.log print message normally:
 !screenshot-2.png! 


> Remove unused slf4j-log4j12 dependency
> --------------------------------------
>
>                 Key: RATIS-1272
>                 URL: https://issues.apache.org/jira/browse/RATIS-1272
>             Project: Ratis
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>         Attachments: screenshot-1.png, screenshot-2.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In some modules, slf4j-log4j12 is not used so that the dependency should be removed.
> In some other modules, slf4j-log4j12 is used only in the tests.  Then, it should use test scope.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)