[GitHub] [cordova-docs] janpio commented on a change in pull request #997: Update Electron Docs

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #997: Update Electron Docs
URL: https://github.com/apache/cordova-docs/pull/997#discussion_r287301829
 
 

 ##########
 File path: www/docs/en/9.x/guide/platforms/electron/index.md
 ##########
 @@ -248,77 +254,75 @@ The `package` property is an array list of packages to be outputted. If the prop
 
 The configuration example below will generate `tar.gz`, `dmg` and `zip` packages for macOS.
 
-```
+```json
 {
-  "electron": {
-    "mac": {
-      "package": [
-        "dmg",
-        "tar.gz",
-        "zip"
-      ]
+    "electron": {
+        "mac": {
+            "package": [
+                "dmg",
+                "tar.gz",
+                "zip"
+            ]
+        }
     }
-  }
 }
 ```
 
 **Available Packages by Operating System**
 
-| Package Type | Linux              | macOS              | Windows                               |
-| ------------ | :----------------: | :----------------: | :-----------------------------------: |
-| default      | -                  | `dmg`<br />`zip`   | -                                     |
-| dmg          | -                  | &#10004;           | -                                     |
-| mas          | -                  | &#10004;           | -                                     |
-| mas-dev      | &#10004;           | -                  | -                                     |
-| pkg          | -                  | &#10004;           | -                                     |
-| 7z           | &#10004;           | &#10004;           | &#10004;                              |
-| zip          | &#10004;           | &#10004;           | &#10004;                              |
-| tar.xz       | &#10004;           | &#10004;           | &#10004;                              |
-| tar.lz       | &#10004;           | &#10004;           | &#10004;                              |
-| tar.gz       | &#10004;           | &#10004;           | &#10004;                              |
-| tar.bz2      | &#10004;           | &#10004;           | &#10004;                              |
-| dir          | &#10004;           | &#10004;           | &#10004;                              |
-| nsis         | -                  | -                  | &#10004;                              |
-| nsis-web     | -                  | -                  | &#10004;                              |
-| portable     | -                  | -                  | &#10004;                              |
-| appx         | -                  | -                  | &#10004; <sup>**[1]**</sup>           |
-| msi          | -                  | -                  | &#10004;                              |
-| AppImage     | &#10004;           | -                  | -                                     |
-| snap         | &#10004;           | -                  | -                                     |
-| deb          | &#10004;           | -                  | -                                     |
-| rpm          | &#10004;           | -                  | -                                     |
-| freebsd      | &#10004;           | -                  | -                                     |
-| pacman       | &#10004;           | -                  | -                                     |
-| p5p          | &#10004;           | -                  | -                                     |
-| apk          | &#10004;           | -                  | -                                     |
-
-* **[1]** Only Window 10 can build AppX packages.
-
-#### Setting the package `arch`
+| Package Type |  Linux  |      macOS       |          Windows           |
+| ------------ | :-----: | :--------------: | :------------------------: |
+| default      |    -    | `dmg`<br />`zip` |             -              |
+| dmg          |    -    |     &#9989;      |             -              |
+| mas          |    -    |     &#9989;      |             -              |
+| mas-dev      | &#9989; |        -         |             -              |
 
 Review comment:
   the diff here looks different than on cordova-electron. were there some changes made in cordova-docs only that were not reflected in cordova-electron or is there something funky going on?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org