You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/02/21 23:53:15 UTC

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4430: DNSSEC refresh breaks on DS if KSK and ZSK both are expired

mhoppa commented on a change in pull request #4430: DNSSEC refresh breaks on DS if KSK and ZSK both are expired
URL: https://github.com/apache/trafficcontrol/pull/4430#discussion_r382858114
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cdn/dnssecrefresh.go
 ##########
 @@ -251,6 +251,10 @@ func doDNSSECKeyRefresh(tx *sql.Tx, cfg *config.Config) {
 				if err != nil {
 					log.Errorln("refreshing DNSSEC Keys: regenerating expired ZSK keys for ds '" + string(ds.DSName) + "': " + err.Error())
 				} else {
+					if existingNewKeys, ok := keys[string(ds.DSName)]; ok {
 
 Review comment:
   yeah maybe I guess. And yeah the key set is returned but it’s overwritten. I mean we can leave it broken w/ the bug since ideally the next cron run will catch the ksk key as long as the expiration date is bigger then a cron time for the zsk key

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services