You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "PhVHoang (via GitHub)" <gi...@apache.org> on 2025/12/28 16:18:41 UTC
[PR] feat: capture more metrics in distributed_query [datafusion-ballista]
PhVHoang opened a new pull request, #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1252 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: capture more metrics in distributed_query [datafusion-ballista]
Posted by "PhVHoang (via GitHub)" <gi...@apache.org>.
PhVHoang commented on code in PR #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353#discussion_r2652198900
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -289,6 +301,8 @@ async fn execute_query(
.max_encoding_message_size(max_message_size)
.max_decoding_message_size(max_message_size);
+ let query_submit_time = std::time::Instant::now();
Review Comment:
Thanks @milenkovicm ,
I think this is a great catch. Using `queued_at` would be more accurate since it’s a server-side timestamp set by the scheduler when the job is queued. This avoids client-side clock skew and ensures the measurement doesn’t include any network latency.
Let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: capture more metrics in distributed_query [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm merged PR #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: capture more metrics in distributed_query [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353#discussion_r2657517163
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -278,7 +285,12 @@ async fn execute_query(
query: ExecuteQueryParams,
max_message_size: usize,
grpc_config: GrpcClientConfig,
+ metrics: Arc<ExecutionPlanMetricsSet>,
+ partition: usize,
Review Comment:
Let's leave it as it is for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: capture more metrics in distributed_query [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353#discussion_r2651658018
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -278,7 +285,12 @@ async fn execute_query(
query: ExecuteQueryParams,
max_message_size: usize,
grpc_config: GrpcClientConfig,
+ metrics: Arc<ExecutionPlanMetricsSet>,
+ partition: usize,
Review Comment:
looks like there is single partition as the result of this exec, so not sure if we need partition here or we could use 0 later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: capture more metrics in distributed_query [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1353:
URL: https://github.com/apache/datafusion-ballista/pull/1353#discussion_r2650888186
##########
ballista/core/src/execution_plans/distributed_query.rs:
##########
@@ -289,6 +301,8 @@ async fn execute_query(
.max_encoding_message_size(max_message_size)
.max_decoding_message_size(max_message_size);
+ let query_submit_time = std::time::Instant::now();
Review Comment:
just wonder if `SuccessfulJob::queued_at` could be used instead of this one? I'm not quite sure, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org