You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/26 18:58:34 UTC

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13199: Pull and build specific LLVM sha for hexagon docker CI

mehrdadh commented on code in PR #13199:
URL: https://github.com/apache/tvm/pull/13199#discussion_r1006077855


##########
docker/install/ubuntu_install_hexagon.sh:
##########
@@ -21,9 +21,26 @@ set -o pipefail
 
 # Install LLVM/clang
 CLANG_LLVM_HOME=/opt/clang-llvm
-CLANG_LLVM_VERSION=14.0.0
-CLANG_LLVM_FILENAME=clang_llvm.tar.xz
-wget -q https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_LLVM_VERSION}/clang+llvm-${CLANG_LLVM_VERSION}-x86_64-linux-gnu-ubuntu-18.04.tar.xz -O ${CLANG_LLVM_FILENAME}
-mkdir ${CLANG_LLVM_HOME}
-tar -xvf ${CLANG_LLVM_FILENAME} -C ${CLANG_LLVM_HOME} --strip-components=1
-rm ${CLANG_LLVM_FILENAME}
+HEXAGON_LLVM_SHA=361a27c155ec8b222e3318488a208c0eb39624c8

Review Comment:
   Please rename this to LLVM_SHA



##########
docker/install/ubuntu_install_hexagon.sh:
##########
@@ -21,9 +21,26 @@ set -o pipefail
 
 # Install LLVM/clang
 CLANG_LLVM_HOME=/opt/clang-llvm

Review Comment:
   `CLANG_LLVM_HOME` is used in hexagon TVM build. Can you change this script to install LLVM in `CLANG_LLVM_HOME` path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org