[GitHub] anirudhacharya commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests

[GitBox <gi...@apache.org>]

anirudhacharya commented on a change in pull request #10216: [WIP] [DO NOT MERGE] Onnx Model Zoo tests
URL: https://github.com/apache/incubator-mxnet/pull/10216#discussion_r176876550
 
 

 ##########
 File path: python/mxnet/contrib/onnx/_import/import_model.py
 ##########
 @@ -46,5 +43,5 @@ def import_model(model_file):
     except ImportError:
         raise ImportError("Onnx and protobuf need to be installed")
     model_proto = onnx.load(model_file)
-    sym, params = graph.from_onnx(model_proto.graph)
-    return sym, params
+    sym, arg_params, aux_params = graph.from_onnx(model_proto.graph)
+    return sym, arg_params, aux_params
 
 Review comment:
   @piiswrong I raised this PR just to check a few things on the CI pipeline. This is the real PR - https://github.com/apache/incubator-mxnet/pull/10118. 
   
   Please kindly give your comments there, I will be closing this PR to avoid any confusion and misunderstanding.
   
   With regard to your concerns. The original code does work. Here is an example that you can try with the latest code on the master - https://github.com/apache/incubator-mxnet/blob/master/example/onnx/super_resolution.py
   
   The current code on master fails for a few models from the onnx model zoo like, resnet50. These changes are to fix that. I understand your concerns and will be mindful in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services