[GitHub] [iceberg] openinx commented on a change in pull request #2258: Core : remove the UnmodifiableMap

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2258:
URL: https://github.com/apache/iceberg/pull/2258#discussion_r595671361



##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -434,7 +433,7 @@ public Integer sortOrderId() {
     if (map != null) {
       Map<K, V> copy = Maps.newHashMapWithExpectedSize(map.size());
       copy.putAll(map);
-      return Collections.unmodifiableMap(copy);

Review comment:
       +1 to fix this BaseFile's kryo serialization issues.  I encountered the same issue when preparing the rewrite action for v2 ( https://github.com/apache/iceberg/pull/2303/files#diff-b51f408c19404436a1cf77f1f31b0a87e5ec1404295f576fc3ca90849de90da0R436).  I read the patch #775,  it just change the `com.google.common.collect.ImmutableList` to `java.util.Collections.UnmodifiableList`, both them does not support the `add` method, so how did the PR fix the kryo issue ?  I did not get the point.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org