You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ps...@apache.org on 2005/09/11 06:30:24 UTC
svn commit: r280068 - in /jakarta/commons/proper/math/branches/MATH_1_1:
src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java
xdocs/changes.xml
Author: psteitz
Date: Sat Sep 10 21:30:10 2005
New Revision: 280068
URL: http://svn.apache.org/viewcvs?rev=280068&view=rev
Log:
Eliminated unnecessary assignment statements in Skewness.getResult
method.
PR# 36491 (findbugs)
Modified:
jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java
jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml
Modified: jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java?rev=280068&r1=280067&r2=280068&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java (original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/src/java/org/apache/commons/math/stat/descriptive/moment/Skewness.java Sat Sep 10 21:30:10 2005
@@ -91,15 +91,13 @@
return Double.NaN;
}
double variance = moment.m2 / (double) (moment.n - 1);
- double skewness = Double.NaN;
if (variance < 10E-20) {
- skewness = 0.0;
+ return 0.0d;
} else {
double n0 = (double) moment.getN();
- skewness = (n0 * moment.m3) /
+ return (n0 * moment.m3) /
((n0 - 1) * (n0 -2) * Math.sqrt(variance) * variance);
}
- return skewness;
}
/**
Modified: jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml?rev=280068&r1=280067&r2=280068&view=diff
==============================================================================
--- jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml (original)
+++ jakarta/commons/proper/math/branches/MATH_1_1/xdocs/changes.xml Sat Sep 10 21:30:10 2005
@@ -46,6 +46,10 @@
possible to replace the JDK-supplied random number generator in
commons-math (and elsewhere) with alternative PRNG implementations.">
<action dev="psteitz" type="fix" issue="36491">
+ Eliminated unnecessary assignment statements in Skewness.getResult
+ method.
+ </action>
+ <action dev="psteitz" type="fix" issue="36491">
Synchronized getters in ResizeableDoubleArray.
</action>
<action dev="psteitz" type="fix" issue="36491">
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org