[GitHub] [trafficcontrol] shamrickus opened a new issue #5902: TO riak client is unable to get more than 1000 records

[GitBox <gi...@apache.org>]

shamrickus opened a new issue #5902:
URL: https://github.com/apache/trafficcontrol/issues/5902


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/slack-invite)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Ops
   -  Traffic Vault
   
   ## Current behavior:
   When using the [search](https://github.com/apache/trafficcontrol/blob/60a9ffdcabdeb011773a900739ec2615da47ab33/traffic_ops/traffic_ops_golang/trafficvault/backends/riaksvc/riak_services.go#L397) feature of Riak, the user has to pass a maximum number of rows that can be turned in a single query. This is [hardcoded to 1000 entries](https://github.com/apache/trafficcontrol/blob/60a9ffdcabdeb011773a900739ec2615da47ab33/traffic_ops/traffic_ops_golang/trafficvault/backends/riaksvc/dsutil.go#L342).
   
   The endpoints using this search query are
   `GET cdns/name/{name}/sslkeys` -> Gets all sslkeys for DS's on a CDN
   `DELETE snapshot/` -> Deletes old sslkeys on a DS for a CDN
   
   In effect, this means that if you have a CDN with over 1000 thousand DS's with sslkeys, the client will be unable to get all of the sslkeys.
   In terms of deleting, if _any_ change is made to a CDN with over 1000 keys, then only the first 1000 sslkey records for that CDN will be correctly cleaned up.
   
   
   <!-- Describe how the bug manifests -->
   
   ## Expected behavior:
   CDN works as expected regardless of the number of sslkeys. Specifically `GET cdns/name/{name}/sslkeys` should be able to return more than 1000 records and `DELETE snapshot/` should cleanup all sslkeys, regardless of total count.
   <!-- Describe what the behavior would be without the bug -->
   
   ## Minimal reproduction of the problem with instructions:
   Create a CDN with over a thousand DS' that have sslkeys. 
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   
   <!--
   e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
   this section)
   -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mattjackson220 closed issue #5902: TO riak client is unable to get more than 1000 records

[GitBox <gi...@apache.org>]

mattjackson220 closed issue #5902:
URL: https://github.com/apache/trafficcontrol/issues/5902


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org