Re: [PR] kie-issues#1143: DMN Editor throws an error when deleting Unknown nodes [incubator-kie-tools]

["ljmotta (via GitHub)" <gi...@apache.org>]

ljmotta commented on code in PR #2288:
URL: https://github.com/apache/incubator-kie-tools/pull/2288#discussion_r1590711136


##########
packages/dmn-editor/src/mutations/deleteNode.ts:
##########
@@ -131,7 +131,7 @@ export function deleteNode({
       throw new Error(`DMN MUTATION: Unknown node nature '${nodeNature}'.`);
     }
 
-    if (!dmnObject) {
+    if (!dmnObject && nodeNature !== NodeNature.UNKNOWN) {

Review Comment:
   I guess you could add a comment here about the `Unkwown` node having a `DMNShape`. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org