[GitHub] [airflow] potiuk edited a comment on pull request #19729: Local kubernetes executor

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #19729:
URL: https://github.com/apache/airflow/pull/19729#issuecomment-1042916898


   One comment - before merge (and @subkanthi  - maybe you can take a closer look while you are adding it). 
   
   There is a bug with CeleryKubernetesExecutor reported recently https://github.com/apache/airflow/issues/21548 which might also affect LocalKubernetesExecutor. Would it be possible that you take a look @subkanthi  - and maybe you will be able to fix it as general case ? And maybe also take a look if there are other places where we have "hard-coded" Executor names
   
   This was one thing that I was afraid of when we discussed "Generic Combined Excecutor" - seems that there might be at least  this one place pointed out in #21548 where we implemented logic based on the type of executor configured and about the executor actually 'used" when the task was executed. 
   
   I think that LocalKubernetesExecutor might suffer the same problem actually - because `file_task_handler` was not touched by this PR.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org