[GitHub] [hive] ramesh0201 commented on a diff in pull request #4379: HIVE-27293 Vectorization: Incorrect results with nvl for ORC table

["ramesh0201 (via GitHub)" <gi...@apache.org>]

ramesh0201 commented on code in PR #4379:
URL: https://github.com/apache/hive/pull/4379#discussion_r1214889877


##########
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/Decimal64ColumnVector.java:
##########
@@ -136,12 +136,12 @@ public void setElement(int outputElementNum, int inputElementNum, ColumnVector i
           decimal64ColVector.vector[inputElementNum], decimal64ColVector.scale);
       scratchHiveDecWritable.mutateEnforcePrecisionScale(precision, scale);
       if (scratchHiveDecWritable.isSet()) {
-        vector[inputElementNum] = scratchHiveDecWritable.serialize64(scale);
+        vector[outputElementNum] = scratchHiveDecWritable.serialize64(scale);

Review Comment:
   Yes, not for the primitive column vectors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org