You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/31 03:35:42 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #2111: [Bug] [config-ui] Connection Save too slowly
likyh opened a new issue, #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
Connection Save too slowly. It's always 2s even thouth it's in local network.
### What you expected to happen
Save success when api response.
### How to reproduce
1. create a connection and save it.
2. look how long it succeed.
### Anything else
_No response_
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
likyh closed issue #2111: [Bug] [config-ui] Connection Save too slowly
URL: https://github.com/apache/incubator-devlake/issues/2111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111#issuecomment-1200540296
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111#issuecomment-1148905857
This is not a bug there must be some specific reason this is wrapped in a timeout, most likely for UI latency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111#issuecomment-1148862177
I think the reason of this issue is `ToastNotification.clear()` in other network request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
likyh closed issue #2111: [Bug] [config-ui] Connection Save too slowly
URL: https://github.com/apache/incubator-devlake/issues/2111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111#issuecomment-1149371848
The api request function should return when success and only return slowly when timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #2111: [Bug] [config-ui] Connection Save too slowly
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2111:
URL: https://github.com/apache/incubator-devlake/issues/2111#issuecomment-1149877920
No, this logic executes after a save or modify operation is performed (lines `193 - 196`). The timeout here is used for UI alerting once completed, the connection response is stored as $saveComplete, additionally a Test Connection routine is performed for only JIRA and GitHub Providers that have a token specified.
Ideally this logic would live inside another effect, thereby removing the need for a timeout wrapper. I can revisit this logic, I would need more details as to what exact problem you are experiencing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org