You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/05/24 02:53:31 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #5882: [Bug] Fix the bug of `nullif` function:
HappenLee opened a new pull request #5882:
URL: https://github.com/apache/incubator-doris/pull/5882
## Proposed changes
1. Prevent return NULL call nullif(98, null) in FE
2. Support DecimalV2 of nullif function to get the right result
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #5858) and described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [x] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5882: [Bug] Fix the bug of `nullif` function:
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5882:
URL: https://github.com/apache/incubator-doris/pull/5882#issuecomment-846719476
> non_null_result_with_null_param_functions
Great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5882: [Bug] Fix the bug of `nullif` function:
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5882:
URL: https://github.com/apache/incubator-doris/pull/5882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #5882: [Bug] Fix the bug of `nullif` function:
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #5882:
URL: https://github.com/apache/incubator-doris/pull/5882#issuecomment-846700225
> what if SELECT ALL NULLIF (-98, NULL) AS col0 ?
The right result of nullif(-98, null) is -98. but before fix the bug, the answer is `null`. Because the FE wiil treat all the function not in `non_null_result_with_null_param_functions` alwalys `null` if there params have `null`.
so add the `nullif` function to `non_null_result_with_null_param_functions` we can get the right answer:`98`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org