You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/15 23:28:29 UTC
[GitHub] [zookeeper] jhuan31 opened a new pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
jhuan31 opened a new pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-693173952
@hanm yes we can commit it
I will take care of that today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-648994569
I have triggered Travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 closed pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
jhuan31 closed pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-692988420
@jhuan31 The latest pre-merge job pass - looks like we don't have any issues on C client side. I also verified this pull request locally (CentOS) and all C client test pass. Not sure why the previous pre-merge job gives specific errors on read-only related test failures.
@eolivelli Since we have a green build (pre-merge) now, should we commit this change? Both of us is +1 on this. I hope I can trigger a JenkinsMaven build for this but I don't know how - a green pre-merge build seems enough.
This will be a very valuable additions to ZooKeeper as it fixes ReadOnly mode, which is super useful for service discovery use cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-647921220
This PR now includes ZOOKEEPER-3863 and ZOOKEEPER-3864 and updated unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-648551971
retest maven build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-652492740
ah, didn't know that C test needs to be updated too. taking a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-649112792
I did a super quick look on the C test, looks like no easy way to programmatically enable local session on the `ZooKeeperQuorumServer`. One approach is to create a read only test specific zoo.cfg and enable local session in the config file, instead of doing it programmatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-691722787
retest maven build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-648988122
retest maven build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-649109265
Making good progress now, with Travis green :)
Jenkins is consistently failing with C client read-only tests:
`[exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/tests/TestReadOnlyClient.cc:100: Assertion: equality assertion failed [Expected: 0, Actual : -7]
[exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/tests/TestReadOnlyClient.cc:100: Assertion: equality assertion failed [Expected: 0, Actual : -7]
[exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/tests/TestSASLAuth.cc:214: Assertion: assertion failed [Expression: ctx.waitForConnected(zk)]
[exec] Failures !!!
[exec] Run: 88 Failure total: 3 Failures: 3 Errors: 0`
@jhuan31 I think we need update C read only test similar like we did for Java test to explicit set/enable local session in test, because we are now rejecting global session for read only servers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] wyp12 removed a comment on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
wyp12 removed a comment on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-650725036
test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] jhuan31 commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
jhuan31 commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-648357556
can't figure out what's wrong with the build. The only msg is "An error occurred while generating the build script."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] wyp12 commented on pull request #1380: ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer
Posted by GitBox <gi...@apache.org>.
wyp12 commented on pull request #1380:
URL: https://github.com/apache/zookeeper/pull/1380#issuecomment-650725036
test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org