You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Fabulich (JIRA)" <ji...@codehaus.org> on 2007/12/08 00:03:57 UTC

[jira] Created: (MSHADE-5) 50% of the time I run the shade plugin, it's unable to replace the original jar

50% of the time I run the shade plugin, it's unable to replace the original jar
-------------------------------------------------------------------------------

                 Key: MSHADE-5
                 URL: http://jira.codehaus.org/browse/MSHADE-5
             Project: Maven 2.x Shade Plugin
          Issue Type: Bug
         Environment: Windows XP SP2, Java 1.5.0_12
            Reporter: Dan Fabulich
            Priority: Blocker


I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSHADE-5) 5% of the time I run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich updated MSHADE-5:
------------------------------

    Summary: 5% of the time I run the shade plugin, it's unable to replace the original jar  (was: 50% of the time I run the shade plugin, it's unable to replace the original jar)

Now it's closer to 5% of the time, instead of the original 50%.

> 5% of the time I run the shade plugin, it's unable to replace the original jar
> ------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSHADE-5) Whenever I do a deploy and run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich updated MSHADE-5:
------------------------------

    Priority: Blocker  (was: Major)
     Summary: Whenever I do a deploy and run the shade plugin, it's unable to replace the original jar  (was: 5% of the time I run the shade plugin, it's unable to replace the original jar)

I just discovered that this problem occurs every time I try to deploy a snapshot that uses shade!  This is a blocker after all.

> Whenever I do a deploy and run the shade plugin, it's unable to replace the original jar
> ----------------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MSHADE-5) 50% of the time I run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed MSHADE-5.
-----------------------------

    Resolution: Fixed

Yup, that fixed it.

> 50% of the time I run the shade plugin, it's unable to replace the original jar
> -------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MSHADE-5) 50% of the time I run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich reopened MSHADE-5:
-------------------------------


Actually, it seems that it just made the issue much more rare.  Unfortunately, it stung me just as I went to deploy the latest Surefire 2.4-SNAPSHOT today.

> 50% of the time I run the shade plugin, it's unable to replace the original jar
> -------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MSHADE-5) Whenever I do a deploy and run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich closed MSHADE-5.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 1.0-alpha-14

Fixed again in revisions 603267 603291 603295

> Whenever I do a deploy and run the shade plugin, it's unable to replace the original jar
> ----------------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>             Fix For: 1.0-alpha-14
>
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MSHADE-5) 5% of the time I run the shade plugin, it's unable to replace the original jar

Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Fabulich updated MSHADE-5:
------------------------------

    Priority: Major  (was: Blocker)

> 5% of the time I run the shade plugin, it's unable to replace the original jar
> ------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MSHADE-5) 50% of the time I run the shade plugin, it's unable to replace the original jar

Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MSHADE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116228 ] 

Daniel Kulp commented on MSHADE-5:
----------------------------------


I have no way of testing this (no windows boxes), but looking at the code, we never called jarFile.close on the jars we were reading.   Thus, the file was probably locked.   I fixed that.   I'd appreciate it if you could see if that helps.


> 50% of the time I run the shade plugin, it's unable to replace the original jar
> -------------------------------------------------------------------------------
>
>                 Key: MSHADE-5
>                 URL: http://jira.codehaus.org/browse/MSHADE-5
>             Project: Maven 2.x Shade Plugin
>          Issue Type: Bug
>         Environment: Windows XP SP2, Java 1.5.0_12
>            Reporter: Dan Fabulich
>            Priority: Blocker
>
> I tried to wire up the shade plugin in surefire trunk.  About 50% of the time I run the shade plugin I get a "[WARNING] Could not replace original artifact with shaded artifact!"  IMO that should halt the build, because it goes on to use the stripped POM without using the shaded jar; hilarity ensues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira