You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2025/04/22 16:47:33 UTC
[I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
amoeba opened a new issue, #46207:
URL: https://github.com/apache/arrow/issues/46207
### Describe the enhancement requested
[During review](https://github.com/apache/arrow/pull/46180#discussion_r2053064581) of https://github.com/apache/arrow/pull/46180, it came up that Arrow C++ has two `StringBuilder`s:
1. The public builder for utf8() arrays, https://github.com/apache/arrow/blob/main/cpp/src/arrow/array/builder_binary.h#L424 (class)
2. A helper in https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/string_builder.h (function)
We should,
1. Move StringBuilder (2) in cpp/src/arrow/util/string_builder.h from `arrow::util` to `arrow::internal` to make its intended use more clear
2. Rename from StringBuilder to something else to avoid confusing humans and computers
No changes would be made to the official Arrow StringBuilder class.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
Posted by "Ziy1-Tan (via GitHub)" <gi...@apache.org>.
Ziy1-Tan commented on issue #46207:
URL: https://github.com/apache/arrow/issues/46207#issuecomment-2954142908
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou closed issue #46207: [C++] Rename arrow::util::StringBuilder and move to internal namespace
URL: https://github.com/apache/arrow/issues/46207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #46207:
URL: https://github.com/apache/arrow/issues/46207#issuecomment-2945031363
@amoeba Would you like to tackle this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
Posted by "bkietz (via GitHub)" <gi...@apache.org>.
bkietz commented on issue #46207:
URL: https://github.com/apache/arrow/issues/46207#issuecomment-2822392479
It's worth noting that `arrow::util::StringBuilderRecursive()` (and possibly `arrow::util::StringBuilder` itself) is a helper function which is no longer necessary in C++17 at all; we can use fold expressions to achieve the same result:
```c++
template <typename... Args>
static Status FromArgs(StatusCode code, const Args&... args) {
std::stringstream ss;
(ss << ... << args);
return Status(code, ss.str());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #46207:
URL: https://github.com/apache/arrow/issues/46207#issuecomment-3022956428
Issue resolved by pull request 46813
https://github.com/apache/arrow/pull/46813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org