You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/28 18:56:28 UTC
[GitHub] [pulsar] jerrypeng opened a new pull request #7930: Allow specifying state storage url for Source/Sink localrun
jerrypeng opened a new pull request #7930:
URL: https://github.com/apache/pulsar/pull/7930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #7930: Allow specifying state storage url for Source/Sink localrun
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #7930:
URL: https://github.com/apache/pulsar/pull/7930#discussion_r479545924
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -127,6 +127,8 @@ void processArguments() throws Exception {
@Parameters(commandDescription = "Run a Pulsar IO sink connector locally (rather than deploying it to the Pulsar cluster)")
protected class LocalSinkRunner extends CreateSink {
+ @Parameter(names = "--state-storage-service-url", description = "The URL for the state storage service (the default is Apache BookKeeper)")
Review comment:
Why is this using the old naming scheme ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #7930: Allow specifying state storage url for Source/Sink localrun
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #7930:
URL: https://github.com/apache/pulsar/pull/7930#issuecomment-683108992
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #7930: Allow specifying state storage url for Source/Sink localrun
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #7930:
URL: https://github.com/apache/pulsar/pull/7930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7930: Allow specifying state storage url for Source/Sink localrun
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7930:
URL: https://github.com/apache/pulsar/pull/7930#discussion_r479547289
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
##########
@@ -127,6 +127,8 @@ void processArguments() throws Exception {
@Parameters(commandDescription = "Run a Pulsar IO sink connector locally (rather than deploying it to the Pulsar cluster)")
protected class LocalSinkRunner extends CreateSink {
+ @Parameter(names = "--state-storage-service-url", description = "The URL for the state storage service (the default is Apache BookKeeper)")
Review comment:
@aahmed-se this is the current naming scheme
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org