You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/07 18:46:38 UTC
[jira] [Commented] (SAMZA-1121) StreamAppender should not propagate
exceptions to caller
[ https://issues.apache.org/jira/browse/SAMZA-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899924#comment-15899924 ]
ASF GitHub Bot commented on SAMZA-1121:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/78
SAMZA-1121: StreamAppender should not propagate exceptions to the caller
StreamAppender#append currently propagates any exceptions while sending messages to the underlying logging system to the calling code. Since users don't expect log statements to throw exceptions, this can cause unexpected failures scenarios. We should catch exceptions and log to stderr instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza stream-appender-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
commit 1809c5d2f94e414be84433160e5298ed65759ada
Author: Prateek Maheshwari <pm...@linkedin.com>
Date: 2017-03-07T00:25:44Z
SAMZA-1121: StreamAppender should not propagate exceptions to the caller
----
> StreamAppender should not propagate exceptions to caller
> --------------------------------------------------------
>
> Key: SAMZA-1121
> URL: https://issues.apache.org/jira/browse/SAMZA-1121
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Assignee: Prateek Maheshwari
>
> StreamAppender#append currently propagates any exceptions while sending messages to the underlying logging system to the calling code. Since users don't expect log statements to throw exceptions, this can cause unexpected failures.
> We should catch exceptions and log to stderr instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)