You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/26 13:28:11 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #12904: [TIR] Refactor IndexMap::Inverse in terms of NonSurjectiveInverse
Lunderberg opened a new pull request, #12904:
URL: https://github.com/apache/tvm/pull/12904
The two implementations were largely identical, and had implementations that drifted apart, resulting in bugs such as https://github.com/apache/tvm/issues/12852. This commit removes this duplication by writing `Inverse` in terms of `NonSurjectiveInverse`. The merged version of `NonSurjectiveInverse` contains bugfix https://github.com/apache/tvm/pull/11841, that were previously present only in `Inverse`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12904: [TIR] Refactor IndexMap::Inverse in terms of NonSurjectiveInverse
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12904:
URL: https://github.com/apache/tvm/pull/12904#issuecomment-1258712551
Oh ooops! Sorry I merged it in prematurely without a regression test...Feel free to add one as a follow-up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #12904: [TIR] Refactor IndexMap::Inverse in terms of NonSurjectiveInverse
Posted by GitBox <gi...@apache.org>.
junrushao merged PR #12904:
URL: https://github.com/apache/tvm/pull/12904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12904: [TIR] Refactor IndexMap::Inverse in terms of NonSurjectiveInverse
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12904:
URL: https://github.com/apache/tvm/pull/12904#issuecomment-1259658187
No worries, regression test added in #12916.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12904: [TIR] Refactor IndexMap::Inverse in terms of NonSurjectiveInverse
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12904:
URL: https://github.com/apache/tvm/pull/12904#issuecomment-1258337915
CC @vinx13 @zxybazh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org