[GitHub] [flink] TsReaper commented on a change in pull request #16369: [FLINK-22443][streaming-java] Fix overflow in MultipleInputSelectionHandler

[GitBox <gi...@apache.org>]

TsReaper commented on a change in pull request #16369:
URL: https://github.com/apache/flink/pull/16369#discussion_r663793164



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/MultipleInputITCase.scala
##########
@@ -182,6 +182,27 @@ class MultipleInputITCase(shuffleMode: String) extends BatchTestBase {
     )
   }
 
+  @Test
+  def testManyInputs(): Unit = {
+    val rowType = new RowTypeInfo(INT_TYPE_INFO, STRING_TYPE_INFO)
+    val data = Seq(BatchTestBase.row(1, "test"))
+    val nullables: Array[Boolean] = Array(true, true)
+    registerCollection("left_table", data, rowType, "a, b", nullables)
+    registerCollection("right_table", data, rowType, "c, d", nullables)
+
+    val numInputs = 56

Review comment:
       Because the example provided by the user has 56 inputs (after a second check I discover that this should be 55 if we want to follow the user's example). However `MAX_SUPPORTED_INPUT_COUNT` is indeed more reasonable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org