[GitHub] [carbondata] QiangCai commented on a change in pull request #3137: [HOTFIX][CARBONDATA-3304] Distinguish the thread names created by thread pool of CarbonThreadFactory

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #3137: [HOTFIX][CARBONDATA-3304] Distinguish the thread names created by thread pool of CarbonThreadFactory
URL: https://github.com/apache/carbondata/pull/3137#discussion_r264949695
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/unsafe/UnsafeSortDataRows.java
 ##########
 @@ -243,8 +244,8 @@ public void addRow(Object[] row) throws CarbonSortKeyAndGroupByException {
       }
       rowPage.addRow(row, reUsableByteArrayDataOutputStream.get());
     } catch (Exception e) {
-      if (e.getMessage().contains("cannot handle this row. create new page"))
-      {
+      if (e.getMessage().contains("cannot handle this row. create new page")) {
+        LOGGER.info("cannot handle this row. create new page");
 
 Review comment:
   For each row, it will check sort buffer size.
   Better to not log this info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services