You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2023/02/07 14:16:33 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors

poorbarcode opened a new pull request, #19452:
URL: https://github.com/apache/pulsar/pull/19452

   ### Motivation
   The modifier of variables `currentLedgerEntries`, `currentLedgerSize` and `currentLedger` in `ManagedLedegrImpl` changed to `protected` in PR #18265, this PR is for new features, so there is no cherry picking to branch `2.10`.
   
   PR #19404 fixes the problem of the managed ledger, and is already cherry-picked into branch `2.10`, but this PR uses the above change( The modifier changes of some variables ), so the compilation of branch `2.10` errors now.
   
   ### Modifications
   
   change modifier of variables `currentLedgerEntries`, `currentLedgerSize` and `currentLedger` to `default`
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:
   - 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode closed pull request #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors

Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode closed pull request #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors
URL: https://github.com/apache/pulsar/pull/19452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #19452: [branch-2.10] [fix] [ml] Change the modifier of some variables in ManagedLedgerImpl to default to resolve compilation errors

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19452:
URL: https://github.com/apache/pulsar/pull/19452#issuecomment-1463106820

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org