You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/06/07 23:54:48 UTC
[I] add unit test coverage for WorkerBatchInternalQueue [texera]
aglinxinyuan opened a new issue, #5552:
URL: https://github.com/apache/texera/issues/5552
## Background
`WorkerBatchInternalQueue` in `engine/architecture/pythonworker` currently lacks a dedicated unit-spec. It is a trait providing the per-DP-thread mailbox used by the Python worker, with two-priority queues (data + control) and per-channel in-flight byte accounting via `getQueuedCredit`.
## Behavior to pin
| Surface | Contract |
| --- | --- |
| `enqueueData` + `getElement` | round-trips a `DataElement` |
| `enqueueCommand` + `getElement` | round-trips a `ControlElement` |
| `enqueueActorCommand` + `getElement` | round-trips an `ActorCommandElement` |
| Multi-priority dispatch | control elements are returned **before** data elements when both are queued (queue priorities 0 < 1) |
| `getDataQueueLength` | reports the count of data-queue items (excludes control) |
| `getControlQueueLength` / `isControlQueueEmpty` | reports the count of control-queue items |
| `disableDataQueue` | stops `getElement` from picking from the data queue (control items still flow) |
| `enableDataQueue` | re-enables the data queue |
| `getQueuedCredit(sender)` | equals 0 when nothing has been enqueued |
| `getQueuedCredit` after `enqueueData(DataFrame)` | tracks bytes IN minus bytes OUT for that sender |
| `getQueuedCredit` after `getElement` consumes the data | returns to 0 (in == out) |
| `getQueuedCredit` for non-`DataFrame` payloads | does not increment in/out byte counters |
| `getQueuedCredit` across distinct senders | keeps each sender's accounting independent |
## Scope
- New spec file: `WorkerBatchInternalQueueSpec.scala` (matches the `<srcClassName>Spec.scala` convention).
- The trait is instantiated through a small test-only subclass.
- No production-code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for WorkerBatchInternalQueue [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed issue #5552: add unit test coverage for WorkerBatchInternalQueue
URL: https://github.com/apache/texera/issues/5552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org