You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2023/09/13 19:54:00 UTC

[jira] [Commented] (HBASE-28080) correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster

    [ https://issues.apache.org/jira/browse/HBASE-28080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764853#comment-17764853 ] 

Hudson commented on HBASE-28080:
--------------------------------

Results for branch branch-3
	[build #44 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/44/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/44/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/44/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/44/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> correct span name in AbstractRpcBasedConnectionRegistry#getActiveMaster
> -----------------------------------------------------------------------
>
>                 Key: HBASE-28080
>                 URL: https://issues.apache.org/jira/browse/HBASE-28080
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 3.0.0-alpha-4
>            Reporter: ruanhui
>            Assignee: ruanhui
>            Priority: Trivial
>             Fix For: 3.0.0-beta-1
>
>
> It looks like that the span name does not correspond to what is actually done.
>  
> public CompletableFuture<ServerName> getActiveMaster() {
> return tracedFuture(
> () -> this
> .<GetActiveMasterResponse> call(
> (c, s, d) -> s.getActiveMaster(c, GetActiveMasterRequest.getDefaultInstance(), d),
> GetActiveMasterResponse::hasServerName, "getActiveMaster()")
> .thenApply(resp -> ProtobufUtil.toServerName(resp.getServerName())),
> getClass().getSimpleName() + ".getClusterId");
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)