You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/11/05 22:17:33 UTC
[GitHub] [tomcat] pmouawad opened a new pull request #376: Implement Bug 64877
pmouawad opened a new pull request #376:
URL: https://github.com/apache/tomcat/pull/376
Hello,
First thanks for your great product I've been using for years.
Recently, I worked on a project that uses JDBCStore to store sessions.
I had to run performance tests on it.
Those tests revealed a high contention point in this component due to the coarse granularity of synchronization.
The impact was that 1 thread could block hundreds of others leading to high response time at higher scale.
So I implemented (based on existing one) a new one with following differences:
- I kept only the dataSourceName based configuration
- I removed stateful instance variables in order to be able to lift synchronization
This new implementation improved drastically performances.
I am aware that there is duplication with JDBCStore that could be improved but it's a first shot and I lack of time unfortunately.
I hope you can take into account this contribution.
The associated bugzilla enhancement is:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=64877
Regards
Philippe M.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] pmouawad commented on pull request #376: Implement Bug 64877
Posted by GitBox <gi...@apache.org>.
pmouawad commented on pull request #376:
URL: https://github.com/apache/tomcat/pull/376#issuecomment-734270073
Thanks Remy !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher closed pull request #376: Implement Bug 64877
Posted by GitBox <gi...@apache.org>.
rmaucher closed pull request #376:
URL: https://github.com/apache/tomcat/pull/376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #376: Implement Bug 64877
Posted by GitBox <gi...@apache.org>.
rmaucher commented on pull request #376:
URL: https://github.com/apache/tomcat/pull/376#issuecomment-724639920
I meged the PR, sorf of, in Tomcat 10. Thanks ! Also added in 9.0 and 8.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #376: Implement Bug 64877
Posted by GitBox <gi...@apache.org>.
rmaucher commented on pull request #376:
URL: https://github.com/apache/tomcat/pull/376#issuecomment-722999067
At least for Tomcat 10, modifying the existing realm is the way to go. For example, the JDBCRealm was also removed over DataSourceRealm for similar reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org