You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2024/08/02 20:03:22 UTC
[PR] Need to use returned value of substring() [tika]
dk2k opened a new pull request, #1869:
URL: https://github.com/apache/tika/pull/1869
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Need to use returned value of substring() [tika]
Posted by "dk2k (via GitHub)" <gi...@apache.org>.
dk2k commented on PR #1869:
URL: https://github.com/apache/tika/pull/1869#issuecomment-2266824527
@THausherr It's result of code inspection, I've got more to show in additional PRs.
I haven't hit this issue while using softaware.
Another option is to remove entire if {} as it has no effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Need to use returned value of substring() [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1869:
URL: https://github.com/apache/tika/pull/1869#issuecomment-2266972051
Please include "TIKA-4290: " in front of your PR title, and further PRs that deal with bugs / real risks. Don't submit PRs about formatting or style issues or pet peeves. For some reason the boilerplate text didn't appear in your PR, see e.g. #1860. I've created https://issues.apache.org/jira/browse/TIKA-4290 for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Need to use returned value of substring() [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1869:
URL: https://github.com/apache/tika/pull/1869#issuecomment-2266739348
Do you have an example where this part of the code is used, i.e. did you hit a file where it happened? Or did you look at the source code and you or the IDE noticed the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Need to use returned value of substring() [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1869:
URL: https://github.com/apache/tika/pull/1869#issuecomment-2266635028
There's a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4290: Need to use returned value of substring() [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr merged PR #1869:
URL: https://github.com/apache/tika/pull/1869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org