You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2016/06/16 04:57:27 UTC
[GitHub] spark pull request #13702: [SPARK-15980][SQL] Add PushPredicateThroughObject...
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/13702
[SPARK-15980][SQL] Add PushPredicateThroughObjectConsumer rule to Optimizer.
## What changes were proposed in this pull request?
This pr adds `PushPredicateThroughObjectConsumer` rule to push-down predicates through `ObjectConsumer`.
And as an example, I implemented push-down typed filter through `SerializeFromObject`.
## How was this patch tested?
Added tests to check if push-down typed filter through `SerializeFromObject` correctly works.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-15980
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13702
----
commit 492193c32b8c490032153003e679b152f36b130f
Author: Takuya UESHIN <ue...@happy-camper.st>
Date: 2016-06-15T10:16:31Z
Add PushPredicateThroughObjectConsumer rule.
commit 75805a491dca1c4f8b03bae43449c56fc31a5584
Author: Takuya UESHIN <ue...@happy-camper.st>
Date: 2016-06-15T10:21:34Z
Add a test to DatasetSuite to check if map and filter runs correctly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13702
@marmbrus @cloud-fan
Could you review this pr please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13702
**[Test build #60631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60631/consoleFull)** for PR 13702 at commit [`75805a4`](https://github.com/apache/spark/commit/75805a491dca1c4f8b03bae43449c56fc31a5584).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60631/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13702: [SPARK-15980][SQL] Add PushPredicateThroughObject...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin closed the pull request at:
https://github.com/apache/spark/pull/13702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13702
I'm closing this in favor of #13846.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13702
**[Test build #60631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60631/consoleFull)** for PR 13702 at commit [`75805a4`](https://github.com/apache/spark/commit/75805a491dca1c4f8b03bae43449c56fc31a5584).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13702: [SPARK-15980][SQL] Add PushPredicateThroughObjectConsume...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13702
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org