You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/28 09:11:20 UTC

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

Hello Alexey Serbin, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15577

to review the following change.


Change subject: logging: remove kudu::Bind usage from LoggingCallback
......................................................................

logging: remove kudu::Bind usage from LoggingCallback

Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
---
M src/kudu/client/client.cc
M src/kudu/util/logging.cc
M src/kudu/util/logging_callback.h
3 files changed, 15 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15577/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
Gerrit-Change-Number: 15577
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15577 )

Change subject: logging: remove kudu::Bind usage from LoggingCallback
......................................................................

logging: remove kudu::Bind usage from LoggingCallback

Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
Reviewed-on: http://gerrit.cloudera.org:8080/15577
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/util/logging.cc
M src/kudu/util/logging_callback.h
3 files changed, 15 insertions(+), 17 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
Gerrit-Change-Number: 15577
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15577 )

Change subject: logging: remove kudu::Bind usage from LoggingCallback
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
Gerrit-Change-Number: 15577
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 06:00:02 +0000
Gerrit-HasComments: No

[kudu-CR] logging: remove kudu::Bind usage from LoggingCallback

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15577 )

Change subject: logging: remove kudu::Bind usage from LoggingCallback
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d3c995617ace2a5974be1104fa6f22b3ee5acea
Gerrit-Change-Number: 15577
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 30 Mar 2020 03:13:13 +0000
Gerrit-HasComments: No