You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/10/17 13:38:07 UTC
Re: Review Request 71618: RANGER-2622 : Ranger UI side code
improvement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71618/
-----------------------------------------------------------
(Updated Oct. 17, 2019, 1:38 p.m.)
Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2622
https://issues.apache.org/jira/browse/RANGER-2622
Repository: ranger
Description
-------
* Displayed wrong message while roles updating.
* Role creation time, displayed wrong validation message for role name.
* Audit -> admin tab, log popup details for changing user role to key auditor role not render properly.
* Ranger policy details popup, Revert policy button not able to revert policy to previous/next state if policy contains 'condition' attribute.
* Go to roles tab, if there are no roles found, the message displayed says “No groups found”.
* If a role is checked and unsuccessful role delete is performed, role is still checked after error and on retry UI gives error to select the role although it is already checked.
Diffs
-----
security-admin/src/main/webapp/scripts/models/VXRole.js c12ac2d
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 5811ccf
security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 36f9a2d
security-admin/src/main/webapp/scripts/views/users/RoleCreate.js 91da5ab
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js dabad17
Diff: https://reviews.apache.org/r/71618/diff/2/
Testing
-------
* Tested that role update give proper message 'Role updated successfully'.
* Displayed proper validation message for role name.
* Log popup details for changing user role to key auditor role render properly.
* Ranger policy details popup, Revert policy button able to revert policy to previous/next state if policy contains 'condition' attribute.
Thanks,
Nitin Galave
Re: Review Request 71618: RANGER-2622 : Ranger UI side code
improvement.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71618/#review218266
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Oct. 17, 2019, 1:38 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71618/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2019, 1:38 p.m.)
>
>
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2622
> https://issues.apache.org/jira/browse/RANGER-2622
>
>
> Repository: ranger
>
>
> Description
> -------
>
> * Displayed wrong message while roles updating.
> * Role creation time, displayed wrong validation message for role name.
> * Audit -> admin tab, log popup details for changing user role to key auditor role not render properly.
> * Ranger policy details popup, Revert policy button not able to revert policy to previous/next state if policy contains 'condition' attribute.
> * Go to roles tab, if there are no roles found, the message displayed says “No groups found”.
> * If a role is checked and unsuccessful role delete is performed, role is still checked after error and on retry UI gives error to select the role although it is already checked.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/VXRole.js c12ac2d
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 5811ccf
> security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 36f9a2d
> security-admin/src/main/webapp/scripts/views/users/RoleCreate.js 91da5ab
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js dabad17
>
>
> Diff: https://reviews.apache.org/r/71618/diff/2/
>
>
> Testing
> -------
>
> * Tested that role update give proper message 'Role updated successfully'.
> * Displayed proper validation message for role name.
> * Log popup details for changing user role to key auditor role render properly.
> * Ranger policy details popup, Revert policy button able to revert policy to previous/next state if policy contains 'condition' attribute.
>
>
> Thanks,
>
> Nitin Galave
>
>