You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Benson Margulies <bi...@gmail.com> on 2014/01/30 01:36:58 UTC

Closing a PR

As a committer can I get my github ID added so that I can close PR's?

bimargulies would be the relevant ID.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Closing a PR

Posted by Benson Margulies <bi...@gmail.com>.
Was that supposed to be my svn commit message :-)

On Wed, Jan 29, 2014 at 7:42 PM, Robert Muir <rc...@gmail.com> wrote:
> the way to close is to add "closes #x" to your commit message
>
>
> On Wed, Jan 29, 2014 at 4:36 PM, Benson Margulies <bi...@gmail.com>
> wrote:
>>
>> As a committer can I get my github ID added so that I can close PR's?
>>
>> bimargulies would be the relevant ID.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Closing a PR

Posted by Robert Muir <rc...@gmail.com>.
the way to close is to add "closes #x" to your commit message


On Wed, Jan 29, 2014 at 4:36 PM, Benson Margulies <bi...@gmail.com>wrote:

> As a committer can I get my github ID added so that I can close PR's?
>
> bimargulies would be the relevant ID.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>