You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org> on 2022/03/07 20:54:47 UTC

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Yu-Wen Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18296


Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
1 file changed, 12 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7928/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 6
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Mar 2022 18:04:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 7
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Mar 2022 19:41:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
3 files changed, 18 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 6
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7928/


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 6
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Mar 2022 23:11:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10274/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 17:29:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@486
PS3, Line 486:     public static byte[] serializeIcebergSerializableTable(SerializableTable serializableTableTable) {
line too long (102 > 90)


http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@508
PS3, Line 508:     public static SerializableTable deserializeIcebergSerializableTable(byte[] serializedTable)
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@87
PS3, Line 87:       SerializableTable icebergSerializableTable = FeIcebergTable.Utils.deserializeIcebergSerializableTable(
line too long (108 > 90)


http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@96
PS3, Line 96:       return new LocalIcebergTable(db, msTable, ref, colMap, tableInfo, icebergSerializableTable);
line too long (98 > 90)


http://gerrit.cloudera.org:8080/#/c/18296/3/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@105
PS3, Line 105:       ColumnMap cmap, TPartialTableInfo tableInfo, SerializableTable icebergSerializableTable)
line too long (94 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 00:53:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10269/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:13:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7919/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:21:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Besides, we also need to fix ClassCastException after SerializableTable
is added to iceberg. Since BaseTable is always transformed to
SerializableTable for serialization, we cannot restore BaseTable after
deserializing it.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
10 files changed, 63 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7919/


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 03:01:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10288/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 7
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Sun, 13 Mar 2022 07:00:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7915/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 20:57:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Reviewed-on: http://gerrit.cloudera.org:8080/18296
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>
---
M bin/impala-config.sh
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
3 files changed, 24 insertions(+), 24 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Aman Sinha: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 8
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Besides, we also need to fix ClassCastException after SerializableTable
is added to iceberg. Since BaseTable is always transformed to
SerializableTable for serialization, we cannot restore BaseTable after
deserializing it.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
10 files changed, 68 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 6
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 11 Mar 2022 18:21:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Besides, we also need to fix ClassCastException after SerializableTable
is added to iceberg. Since BaseTable is always transformed to
SerializableTable for serialization, we cannot restore BaseTable after
deserializing it.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
M common/thrift/CatalogObjects.thrift
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java
M fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
10 files changed, 67 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10268/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Mar 2022 21:16:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7915/


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Mar 2022 06:57:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10270/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Mar 2022 01:19:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 23144489

Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18296 )

Change subject: Bump up CDP_BUILD_NUMBER to 23144489
......................................................................

Bump up CDP_BUILD_NUMBER to 23144489

This patch is to include HIVE-25753, which is needed to improve the
performance of retrieving the latest committed compaction for a table.

Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
---
M bin/impala-config.sh
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
3 files changed, 24 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18296/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd4ae0cba48217483a40a51f97156fabfb00cf27
Gerrit-Change-Number: 18296
Gerrit-PatchSet: 7
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>