You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/12/02 18:53:12 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/166
TINKERPOP3-860 Bindings applied to the PluginAcceptor should appear to Gremlin Server
Bindings from plugins were being pushed into the ScriptEngine context but were not being merged into the bindings used on eval. They had to be merged together. In doing this, I also found a bug where plugins could conflict with one another (i.e. the first plugin would install, then the second would come along an blow out what the previous one had done) - fixed that. Added test cases to cover these scenarios.
I tested with:
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -pl gremlin-server
mvn verify -DskipIntegrationTests=false -pl gremlin-groovy
```
and also tested Gremlin Server manually:
```text
gremlin> :remote connect tinkerpop.server conf/remote.yaml
==>Connected - localhost/127.0.0.1:8182
gremlin> :> hdfs.toString()
==>org.apache.hadoop.fs.LocalFileSystem@7154cf94
```
A manual test requires:
```text
bin/gremlin.sh -i org.apache.tinkerpop hadoop-gremlin 3.1.1-SNAPSHOT
```
and editing the gremlin server yaml file to include `tinkerpop.hadoop` in the "plugins" key:
```yaml
plugins:
- tinkerpop.tinkergraph
- tinkerpop.hadoop
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-860
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit b503e41552e533bc4420a968ba591faacd1c6e27
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-02T17:44:36Z
Adjusted ScriptEngines to "merge" bindings.
Bindings from plugins were being pushed into the ScriptEngine context but were not being merged into the bindings used on eval. They had to be merged together. In doing this, I also found a bug where plugins could conflict with one another (i.e. the first plugin would install, then the second would come along an blow out what the previous one had done) - fixed that. Added test cases to cover these scenarios.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/166#issuecomment-161387113
i think the CI failure is related to this:
https://issues.apache.org/jira/browse/TINKERPOP3-1006
and not my changes in particular.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/166#issuecomment-162021263
Code / configurations look good. Also the logs in Travis are still verbose enough to see what's going on. Nice.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/166#issuecomment-162004676
Travis is happy now - votes anyone? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-860 Bindings applied ...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/166#issuecomment-162033734
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---